Skip to content

fix(p2p): fix websocket log line parsing in exec p2p/simulations adapter #16667#2008

Merged
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:fix-ws-log-line-parse
Feb 6, 2026
Merged

fix(p2p): fix websocket log line parsing in exec p2p/simulations adapter #16667#2008
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:fix-ws-log-line-parse

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

@gzliudan gzliudan commented Jan 28, 2026

Proposed changes

Ref: ethereum#16667

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings January 28, 2026 07:04
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 28, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug in the WebSocket log line parsing for the p2p/simulations exec adapter. The issue was that the code was looking for a log message with "WebSocket endpoint opened:" (with a colon), but the actual log message produced by the node is "WebSocket endpoint opened" (without a colon). This caused the exec adapter to timeout when trying to start nodes in simulations.

Changes:

  • Fixed the WebSocket endpoint log message string matching to remove the incorrect colon
  • Refactored the WebSocket address parsing logic into a separate file (ws.go) for better code organization
  • Added test coverage for the WebSocket address parsing functionality

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
p2p/simulations/adapters/ws.go New file containing extracted WebSocket address parsing logic with the bug fix
p2p/simulations/adapters/ws_test.go New test file validating the WebSocket address parsing functionality
p2p/simulations/adapters/exec.go Refactored to use the extracted functions, removing inline WebSocket parsing code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread p2p/simulations/adapters/ws.go
Comment thread p2p/simulations/adapters/ws_test.go
Comment thread p2p/simulations/adapters/ws.go
@gzliudan gzliudan changed the title p2p: fix websocket log line parsing in exec p2p/simulations adapter #16667 fix(p2p): fix websocket log line parsing in exec p2p/simulations adapter #16667 Feb 5, 2026
@gzliudan gzliudan force-pushed the fix-ws-log-line-parse branch from e6745c9 to cd0bb7f Compare February 5, 2026 09:10
@AnilChinchawale AnilChinchawale merged commit 70e17f0 into XinFinOrg:dev-upgrade Feb 6, 2026
13 checks passed
@gzliudan gzliudan deleted the fix-ws-log-line-parse branch February 6, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@AnilChinchawale AnilChinchawale AnilChinchawale approved these changes

@benjamin202410 benjamin202410 benjamin202410 approved these changes

@anunay-xin anunay-xin anunay-xin approved these changes

@liam-lai liam-lai Awaiting requested review from liam-lai

@wanwiset25 wanwiset25 Awaiting requested review from wanwiset25

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gzliudan @AnilChinchawale @benjamin202410 @anunay-xin